Re: [PATCH] pinctrl: mediatek: fix dependencies for PINCTRL_MT76XX
From: Sean Wang <sean.wang@kernel.org>
Date: 2019-01-29 04:59:24
Also in:
linux-gpio, linux-mediatek, lkml
On Mon, Jan 28, 2019 at 2:35 PM Dmitry Voytik [off-list ref] wrote:
quoted hunk ↗ jump to hunk
How to reproduce the problem: $ make tinyconfig $ make menuconfig then enable: CONFIG_COMPILE_TEST=y CONFIG_PINCTRL=y and any of these: CONFIG_PINCTRL_MT7622=y CONFIG_PINCTRL_MT7629=y CONFIG_PINCTRL_MT7623=y This combination causes build failure. Fix the problem by making PINCTRL_MT76XX to depend on CONFIG_OF=y. Signed-off-by: Dmitry Voytik <redacted> --- drivers/pinctrl/mediatek/Kconfig | 3 +++ 1 file changed, 3 insertions(+)diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig index 1817786ab6aa..a005cbccb4f7 100644 --- a/drivers/pinctrl/mediatek/Kconfig +++ b/drivers/pinctrl/mediatek/Kconfig@@ -45,12 +45,14 @@ config PINCTRL_MT2701 config PINCTRL_MT7623 bool "Mediatek MT7623 pin control with generic binding" depends on MACH_MT7623 || COMPILE_TEST + depends on OF default MACH_MT7623 select PINCTRL_MTK_MOORE config PINCTRL_MT7629 bool "Mediatek MT7629 pin control" depends on MACH_MT7629 || COMPILE_TEST + depends on OF default MACH_MT7629 select PINCTRL_MTK_MOORE@@ -92,6 +94,7 @@ config PINCTRL_MT6797 config PINCTRL_MT7622 bool "MediaTek MT7622 pin control" + depends on OF depends on ARM64 || COMPILE_TEST default ARM64 && ARCH_MEDIATEK select PINCTRL_MTK_MOORE --2.20.1
It seems the commit 2d2d478576d71000b29c52668c5712c825ee9af8 already fixed the problem or is there something I'm missing? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel