Re: [PATCH v2 2/3] dma: imx-sdma: add clock ratio 1:1 check
From: Daniel Baluta <hidden>
Date: 2019-01-20 18:00:45
Also in:
dmaengine, lkml
From: Daniel Baluta <hidden>
Date: 2019-01-20 18:00:45
Also in:
dmaengine, lkml
On Sun, Jan 20, 2019 at 4:38 PM Angus Ainslie [off-list ref] wrote:
Hi Daniel, On 2019-01-20 02:58, Daniel Baluta wrote:quoted
On Sun, Jan 20, 2019 at 4:32 AM Angus Ainslie (Purism) [off-list ref] wrote:quoted
On i.mx8 mscale B0 chip, AHB/SDMA clock ratio 2:1 can't be supportted, since SDMA clock ratio has to be increased to 250Mhz, AHB can't reach to 500Mhz, so use 1:1 instead. based on NXP commit MLK-16841-1Hi Angus, Thanks for doing this! I'm not sure specifying the MLK here helps. I think it would be better to somehow add the original Signed-off-by and mention that the commit was pulled from NXP linux-imx tree.If it was exactly the same patch I would have but as I added the lines in sdma_run_channel0 I didn't think it would be right to put signed off by "Robin Gong [off-list ref]" as the code isn't what he signed off on.
I see your point. I often encounter this scenario when sending patches. I think the best solution would be to mention in the commit message the author of the initial patch which you based your work on. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel