Re: [PATCH] clk: zynqmp: Fix memory allocation in zynqmp_clk_setup
From: Michal Simek <hidden>
Date: 2019-01-03 11:03:21
Also in:
linux-clk, lkml
On 24. 12. 18 6:50, Gustavo A. R. Silva wrote:
quoted hunk ↗ jump to hunk
Fix memory allocation and use struct_size() in kzalloc(). Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <redacted> --- drivers/clk/zynqmp/clkc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/clk/zynqmp/clkc.c b/drivers/clk/zynqmp/clkc.c index f65cc0ff76ab..b0908ec62f73 100644 --- a/drivers/clk/zynqmp/clkc.c +++ b/drivers/clk/zynqmp/clkc.c@@ -669,8 +669,8 @@ static int zynqmp_clk_setup(struct device_node *np) if (ret) return ret; - zynqmp_data = kzalloc(sizeof(*zynqmp_data) + sizeof(*zynqmp_data) * - clock_max_idx, GFP_KERNEL); + zynqmp_data = kzalloc(struct_size(zynqmp_data, hws, clock_max_idx), + GFP_KERNEL); if (!zynqmp_data) return -ENOMEM;
Looks good. Description could be maybe more verbose that you are fixing issue that it should be sizeof(struct clk_hw) instead of sizeof(struct clk_hw_onecell_data) Otherwise Acked-by: Michal Simek <redacted> Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel