Re: [PATCH v7 07/25] ACPI / APEI: Remove spurious GHES_TO_CLEAR check
From: Borislav Petkov <bp@alien8.de>
Date: 2018-12-11 17:18:40
Also in:
kvmarm, linux-acpi, linux-mm
On Mon, Dec 03, 2018 at 06:05:55PM +0000, James Morse wrote:
quoted hunk ↗ jump to hunk
ghes_notify_nmi() checks ghes->flags for GHES_TO_CLEAR before going on to __process_error(). This is pointless as ghes_read_estatus() will always set this flag if it returns success, which was checked earlier in the loop. Remove it. Signed-off-by: James Morse <james.morse@arm.com> --- drivers/acpi/apei/ghes.c | 3 --- 1 file changed, 3 deletions(-)diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index acf0c37e9af9..f7a0ff1c785a 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c@@ -936,9 +936,6 @@ static int ghes_notify_nmi(unsigned int cmd, struct pt_regs *regs) __ghes_panic(ghes); } - if (!(ghes->flags & GHES_TO_CLEAR)) - continue; - __process_error(ghes); ghes_clear_estatus(ghes, buf_paddr); }--
Reviewed-by: Borislav Petkov <redacted>
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel