Re: [PATCH v3] pinctrl:mediatek:add EINT support to virtual GPIOs
From: Sean Wang <sean.wang@kernel.org>
Date: 2018-12-27 19:16:01
Also in:
linux-gpio, linux-mediatek, lkml
On Mon, Dec 24, 2018 at 8:25 PM [off-list ref] wrote:
From: Chuanjia Liu <redacted>
there are still some nitpicks an empty char should follow the ':' char
Virtual gpio only used inside SOC and not being exported to outside SOC. Some modules use virtual gpio as eint and doesn't nedd SMT.
s/nedd/need/
quoted hunk ↗ jump to hunk
So this patch add EINT support to virtual GPIOs. Signed-off-by: Chuanjia Liu <redacted> --- change note: v3 : 1. modify subject and description 2. modify comments --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 4a9e0d4c2bbc..a0db145f798d 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c@@ -290,7 +290,15 @@ static int mtk_xt_set_gpio_as_eint(void *data, unsigned long eint_n) return err; err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SMT, MTK_ENABLE); - if (err) + /*
merge the second line to be consistent with the other comment blocks
+ *SMT is supposed to be supported by every real GPIO and doesn't
an empty char should follow '*' char to be consistent with the other comment blocks and also in the other lines starting with '*'
+ *support virtual GPIOs, so the extra condition err != -ENOTSUPP + *is just for adding EINT support to these virtual GPIOs. It should + *add an extra flag in the pin descriptor when more pins with + *distinctive characteristic come out. + */ +
remove the blank line
+ if (err && err != -ENOTSUPP)
return err;
return 0;
--
2.19.1_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel