Re: [Potential Spoof] Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook
From: James Feist <hidden>
Date: 2018-12-17 19:50:03
Also in:
linux-aspeed, linux-devicetree, lkml, openbmc
On 12/17/18 11:39 AM, Vijay Khemka wrote:
On 12/14/18, 12:42 PM, "Linux-aspeed on behalf of Vijay Khemka" <linux-aspeed-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of vijaykhemka@fb.com> wrote:
On 12/14/18, 11:22 AM, "openbmc on behalf of Jae Hyun Yoo" <openbmc-bounces+vijaykhemka=fb.com@lists.ozlabs.org on behalf of jae.hyun.yoo@linux.intel.com> wrote:
Hi Vijay,
On 12/14/2018 10:11 AM, Vijay Khemka wrote:
> On 12/13/18, 2:56 PM, "Joel Stanley" [off-list ref] wrote:
<snip>
> > + oemname0 = "MB_P3V3";
> > + oemname1 = "MB_P5V";
> > + oemname2 = "MB_P12V";
> > + oemname3 = "MB_P1V05";
> > + oemname4 = "MB_PVNN_PCH_STBY";
> > + oemname5 = "MB_P3V3_STBY";
> > + oemname6 = "MB_P5V_STBY";
>
> "oemname" isn't part of the upstream bindings. Is this something you
> have patches for?
> This is a workaround field used by dbus-sensors application to avoid overlay for dynamic detection of devices based on json file definition.
>
> Can you please also review other 3 patches in this series.
>
>
These oemname settings should not be added into here. You can add these
information into configuration of entity manager which uses overlay
templates for dbus-sensors. Also, as Joel said, "oemname" isn't part of
the upstream bindings.
Overlay templates from entity manager is not working for fan and adc sensors that's why it is a workaround suggested by James Feist (Author of dbus-sensors).
@james.feist@linux.intel.com,
Please comment on above patch, please advise if I need to fix this.Yes, this is a workaround. It should not be added to your device tree. This has already been fixed for the fans, someone just needs to spend a little bit of time to fix the ADCs then it won't be needed. Thanks, James
Cheers,
Jae
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel