Re: [PATCH -next] input: keyboard: remove duplicated include from mtk-pmic-keys.c
From: YueHaibing <hidden>
Date: 2018-12-10 07:16:10
Also in:
linux-input, linux-mediatek, lkml
From: YueHaibing <hidden>
Date: 2018-12-10 07:16:10
Also in:
linux-input, linux-mediatek, lkml
On 2018/12/10 14:15, Lee Jones wrote:
On Sun, 09 Dec 2018, YueHaibing wrote:quoted
Remove duplicated include. Signed-off-by: YueHaibing <redacted> --- drivers/input/keyboard/mtk-pmic-keys.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/input/keyboard/mtk-pmic-keys.c b/drivers/input/keyboard/mtk-pmic-keys.c index 02c67a1..5027ebb 100644 --- a/drivers/input/keyboard/mtk-pmic-keys.c +++ b/drivers/input/keyboard/mtk-pmic-keys.c@@ -19,7 +19,6 @@ #include <linux/input.h> #include <linux/interrupt.h> #include <linux/platform_device.h> -#include <linux/kernel.h> #include <linux/of.h> #include <linux/of_device.h> #include <linux/regmap.h>You are removing the wrong one.
No, linux/kernel.h is a duplicated include indeed.
Please convert this patch's main intent to alphabetise the header files. Then you can remove any obvious duplicates.
I can alphabetize it in v2 if need be.
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel