Re: [PATCH v6 8/8] mfd: axp20x: Add supported cells for AXP803
From: Lee Jones <hidden>
Date: 2018-12-07 16:40:18
Also in:
linux-devicetree, linux-pm, lkml
On Tue, 20 Nov 2018, Oskari Lemmela wrote:
quoted hunk ↗ jump to hunk
Parts of the AXP803 are compatible with their counterparts on the AXP813. These include the GPIO, ADC, AC and battery power supplies. Signed-off-by: Oskari Lemmela <redacted> Reviewed-by: Chen-Yu Tsai <redacted> Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> --- drivers/mfd/axp20x.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c index dfc3cff1d08b..e415b967d38c 100644 --- a/drivers/mfd/axp20x.c +++ b/drivers/mfd/axp20x.c@@ -728,11 +728,26 @@ static const struct mfd_cell axp288_cells[] = { static const struct mfd_cell axp803_cells[] = { { + .name = "axp20x-gpio", + .of_compatible = "x-powers,axp813-gpio", + }, { .name = "axp221-pek", .num_resources = ARRAY_SIZE(axp803_pek_resources), .resources = axp803_pek_resources, }, { .name = "axp20x-regulator" }, + { + .name = "axp813-adc", + .of_compatible = "x-powers,axp813-adc", + }, { + .name = "axp20x-battery-power-supply", + .of_compatible = "x-powers,axp813-battery-power-supply", + }, { + .name = "axp20x-ac-power-supply", + .of_compatible = "x-powers,axp813-ac-power-supply", + .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources), + .resources = axp20x_ac_power_supply_resources, + }, };
My OCD-dar is going crazy. Why haven't you used the same alignment as is already there? If it starts to run over 80-chars then bring the others back. Also why is there a single liner shoved in the middle of the multi-line entries? Please move the singles to the top or the bottom. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel