Thread (3 messages) 3 messages, 2 authors, 2018-12-04

Re: Linux-next: Build failed

From: Naresh Kamboju <hidden>
Date: 2018-12-04 14:46:53
Also in: lkml

Hi Will,

On Tue, 4 Dec 2018 at 18:22, Will Deacon [off-list ref] wrote:
Hi Naresh,

On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
quoted
FYI,

The Linux -next build failed due to below warnings/errors.

include/asm-generic/bitops/atomic.h: In function 'set_bit':
include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
of function 'atomic_long_or'; did you mean '__atomic_load_n'?
[-Werror=implicit-function-declaration]
  atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
  ^~~~~~~~~~~~~~
  __atomic_load_n
Ha, I like that the compiler is trying to get us to use its __atomic
builtins here :)

Anyway, you're seeing this because of this previous error in Mark's script:

.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found

even though fold is part of coreutils :/

Do you have grep? Maybe the diff below helps.
Yes. grep is present.
Thanks for the quick patch.

- Naresh
quoted hunk ↗ jump to hunk
Will

--->8
diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
index 9d6be538a987..81d5c32039dd 100755
--- a/scripts/atomic/atomic-tbl.sh
+++ b/scripts/atomic/atomic-tbl.sh
@@ -180,7 +180,7 @@ gen_proto_variants()
 #gen_proto(meta, ...)
 gen_proto() {
        local meta="$1"; shift
-       for m in $(echo "${meta}" | fold -w1); do
+       for m in $(echo "${meta}" | grep -o .); do
                gen_proto_variants "${m}" "$@"
        done
 }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help