Re: [PATCH 1/6] media: dt-bindings: media: sun6i: Separate H3 compatible from A31
From: sakari.ailus@iki.fi
Date: 2018-12-04 13:13:39
Also in:
linux-devicetree, linux-media, lkml
From: sakari.ailus@iki.fi
Date: 2018-12-04 13:13:39
Also in:
linux-devicetree, linux-media, lkml
Hi Chen-Yu, On Mon, Dec 03, 2018 at 05:48:31PM +0800, Chen-Yu Tsai wrote:
On Mon, Dec 3, 2018 at 5:42 PM Jagan Teki [off-list ref] wrote:quoted
On Fri, Nov 30, 2018 at 1:29 PM Chen-Yu Tsai [off-list ref] wrote:quoted
The CSI controller found on the H3 (and H5) is a reduced version of the one found on the A31. It only has 1 channel, instead of 4 channels for time-multiplexed BT.656. Since the H3 is a reduced version, it cannot "fallback" to a compatible that implements more features than it supports. Split out the H3 compatible as a separate entry, with no fallback. Fixes: b7eadaa3a02a ("media: dt-bindings: media: sun6i: Add A31 and H3 compatibles") Signed-off-by: Chen-Yu Tsai <redacted>"media" text appear two times on commit head.Just following what previous commits did. :)
I understand Mauro has a script prefixes everything going through the media tree with "media: " unless it's already there. I'd drop the latter, but perhaps elaborate a bit this is about CSI. Fine details... I think it's fine as-is for now.
quoted
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>BTW, I know you've been trying to get CSI to work on the A64. I have it working for the Bananapi-M64. The CSI SCLK needs to be lowered to 300 MHz or the image gets corrupted. ChenYu
-- Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel