Thread (7 messages) 7 messages, 5 authors, 2019-03-26
STALE2672d REVIEWED: 1 (1M)

[PATCH] drm/fbdev: Make skip_vt_switch the default

From: maarten.lankhorst@linux.intel.com (Maarten Lankhorst)
Date: 2018-11-28 07:17:04
Also in: dri-devel, intel-gfx, linux-rockchip, nouveau

Op 27-11-18 om 18:34 schreef Daniel Vetter:
KMS drivers really should all be able to restore their display state
on resume without fbcon helping out. So make this the default.

Since I'm not entirely foolish, make it only a default, which drivers
can still override. That way when the inevitable regression report
happens I can fix things up with a one-liner plus FIXME comment that
someone should fix up the suspend/resume code in that driver.

But at least all new drivers won't be broken by accident as soon as
you turn off fbcon because "suspend/resume worked when I tested it".

v2: Keep this for radeon because of

commit 18c437caa5b18a235dd65cec224eab54bebcee65
Author: Alex Deucher [off-list ref]
Date:   Tue Nov 14 17:19:29 2017 -0500

    Revert "drm/radeon: dont switch vt on suspend"

Thanks to Michel D?nzer for pointing this one out.
Maybe just reload the gamma lut on resume for radeon, instead of relying on fbcon?

Otherwise patch looks sane, would be nice if radeon was fixed instead of worked around.

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help