Thread (8 messages) flat view 8 messages, 3 authors, 2018-11-13
DORMANTno replies

[PATCH 2/2 v2] mfd: ab8500-core: Return zero in get_register_interruptible()

From: Lee Jones <hidden>
Date: 2018-11-13 07:41:04
Also in: kernel-janitors

On Thu, 25 Oct 2018, Dan Carpenter wrote:
This function is supposed to return zero on success or negative error
codes on error.  Unfortunately, there is a bug so it sometimes returns
non-zero, positive numbers on success.

I noticed this bug during review and I can't test it.  It does appear
that the return is sometimes propogated back to _regmap_read() where all
non-zero returns are treated as failure so this may affect run time.

Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface")
Signed-off-by: Dan Carpenter <redacted>
---
v2: In v1, I introduced an new error path and forgot to drop the lock.

 drivers/mfd/ab8500-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

-- 
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help