Quoting Rob Herring (2018-11-19 11:15:16)

On Sun, Nov 18, 2018 at 11:12 AM Matthias Brugger
[off-list ref] wrote:

quoted

On 11/17/18 12:15 AM, Rob Herring wrote:

quoted

On Fri, Nov 16, 2018 at 01:54:45PM +0100, matthias.bgg at kernel.org wrote:

quoted

-    #clock-cells = <1>;
+
+    mmsys_clk: clock-controller at 14000000 {
+            compatible = "mediatek,mt2712-mmsys-clk";
+            #clock-cells = <1>;

This goes against the general direction of not defining separate nodes
for providers with no resources.

Why do you need this and what does it buy if you have to continue to
support the existing chips?

It would show explicitly that the mmsys block is used to probe two
drivers, one for the gpu and one for the clocks. Otherwise that is
hidden in the drm driver code. I think it is cleaner to describe that in
the device tree.

No, that's maybe cleaner for the driver implementation in the Linux
kernel. What about other OS's or when Linux drivers and subsystems
needs change? Cleaner for DT is design bindings that reflect the h/w.
Hardware is sometimes just messy.

I agree. I fail to see what this patch series is doing besides changing
driver probe and device creation methods and making a backwards
incompatible change to DT. Is there any other benefit here?