Thread (14 messages) 14 messages, 5 authors, 2018-11-21

[PATCH 1/3] ARM: davinci: define gpio interrupts as separate resources

From: Sekhar Nori <hidden>
Date: 2018-11-19 20:52:37
Also in: linux-gpio, lkml, stable

On 13/11/18 7:20 PM, Bartosz Golaszewski wrote:
From: Bartosz Golaszewski <redacted>

Since commit eb3744a2dd01 ("gpio: davinci: Do not assume continuous
IRQ numbering") the davinci GPIO driver fails to probe if we boot
in legacy mode from any of the board files. Since the driver now
expects every interrupt to be defined as a separate resource, split
the definition in devices-da8xx.c instead of having a single continuous
interrupt range.

Fixes: eb3744a2dd01 ("gpio: davinci: Do not assume continuous IRQ numbering")
Cc: stable at vger.kernel.org
Signed-off-by: Bartosz Golaszewski <redacted>
There are a number of other boards that need such fixing too. And the
commit in question does not do a good job of explaining why it was
needed in the first place. The description  just repeats what can be
inferred by reading the patch.


    gpio: davinci: Do not assume continuous IRQ numbering

    Currently the driver assumes that the interrupts are continuous
    and does platform_get_irq only once and assumes the rest are continuous,
    instead call platform_get_irq for all the interrupts and store them
    in an array for later use.

    Signed-off-by: Keerthy [off-list ref]
    Reviewed-by: Grygorii Strashko [off-list ref]
    Signed-off-by: Linus Walleij [off-list ref]


Can we revert the offending commit instead?

Thanks,
Sekhar
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help