Thread (6 messages) 6 messages, 2 authors, 2018-11-27

[PATCH v4 1/4] kgdb: Remove irq flags from roundup

From: Will Deacon <hidden>
Date: 2018-11-14 21:51:27
Also in: linux-mips, linux-sh, linuxppc-dev, lkml, sparclinux

On Mon, Nov 12, 2018 at 10:26:55AM -0800, Douglas Anderson wrote:
The function kgdb_roundup_cpus() was passed a parameter that was
documented as:
quoted
the flags that will be used when restoring the interrupts. There is
local_irq_save() call before kgdb_roundup_cpus().
Nobody used those flags.  Anyone who wanted to temporarily turn on
interrupts just did local_irq_enable() and local_irq_disable() without
looking at them.  So we can definitely remove the flags.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Acked-by: Will Deacon <redacted>

I'm hopeful that you'll keep hacking on kgdb, because it definitely needs
some love in its current state.

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help