On Tue, Nov 13, 2018 at 5:52 PM Andre Przywara [off-list ref] wrote:

On Tue, 13 Nov 2018 16:46:32 +0530
Jagan Teki [off-list ref] wrote:

Hi,

quoted

This patch add support for Bananapi S070WV20-CT16 DSI panel to
BPI-M64 board.

DSI panel connected via board DSI port with,
- DC1SW as AVDD supply

Are you sure of that? I don't see anything in the schematic to support
this. The only power lines that go to the DSI connector are DCDC1 and
PS. DC1SW is only connected to PortD on the SoC and to the Ethernet PHY.
Is there anything I miss?

Thanks for the comment, yes dc1sw is connected in ephy. I have reused
dc1, BSP is attached lcd_power1 to axp81x_dc1sw [1]. I just looking
for someone to comment, may be we can skip this regulator attachment.

quoted

- DCDC1 as DVDD supply

That seems right, but doesn't match with what you write below.

Commit need to fix s/DCDC1/DLDO1

quoted

- PD6 gpio for reset pin
- PD5 gpio for backlight enable pin
- PD7 gpio for backlight vdd supply

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42
+++++++++++++++++++ 1 file changed, 42 insertions(+)

diff --git
a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts index
ef1c90401bb2..6cb010e3bbd9 100644 ---
a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +++
b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts @@ -45,6
+45,7 @@ #include "sun50i-a64.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pwm/pwm.h>

 / {
      model = "BananaPi-M64";

@@ -56,6 +57,15 @@
              serial1 = &uart1;
      };

+     backlight: backlight {
+             compatible = "pwm-backlight";
+             pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>;
+             brightness-levels = <1 2 4 8 16 32 64 128 512>;
+             default-brightness-level = <2>;
+             enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /*

LCD-BL-EN: PD5 */
+             power-supply = <&reg_vdd_backlight>;
+     };
+
      chosen {
              stdout-path = "serial0:115200n8";
      };

@@ -91,6 +101,15 @@
              };
      };

+     reg_vdd_backlight: vdd-backlight {
+             compatible = "regulator-fixed";
+             regulator-name = "vdd-backlight";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* LCD-PWR-EN:

PD7 */
+             enable-active-high;
+     };
+
      wifi_pwrseq: wifi_pwrseq {
              compatible = "mmc-pwrseq-simple";
              reset-gpios = <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */

@@ -101,6 +120,23 @@
      status = "okay";
 };

+&dphy {
+     status = "okay";
+};
+
+&dsi {
+     status = "okay";
+
+     panel at 0 {
+             compatible = "bananapi,s070wv20-ct16-icn6211";
+             reg = <0>;
+             avdd-supply = <&reg_dc1sw>;

As mentioned above, I don't see this on the DSI connector.

quoted

+             dvdd-supply = <&reg_dldo1>;

Mmh, this line is connected to the *SoC*, to drive the DSI data lines
or the DPHY, presumably. So I wouldn't expect it in the panel node, but
rather in the DPHY or DSI node. Although I can't find a power-supply
property in those bindings.

Got it, this has to attach via vcc-dsi-supply.

[1] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/bootloader/blobs/bpi-m64-lcd7.dts#L2266