Thread (2 messages) 2 messages, 2 authors, 2018-11-02

[PATCH v2] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

From: Olof Johansson <hidden>
Date: 2018-11-02 18:48:58
Also in: lkml

On Wed, Oct 31, 2018 at 08:41:34AM +0000, Marc Zyngier wrote:
The Keystone QMSS driver is pretty damaged, in the sense that it
does things like this:

	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));

where cpu_map is a local variable. As we leave the function, this
will point to nowhere-land, and things will end-up badly.

Instead, let's use a proper cpumask that gets allocated, giving
the driver a chance to actually work with things like irqbalance
as well as have a hypothetical 64bit future.

Cc: stable at vger.kernel.org
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Marc Zyngier <redacted>
---
* From v1:
  - Added Santosh's Ack
  - Cc stable
  - Directly sent to arm-soc for immediate pick-up
    (https://lore.kernel.org/lkml/0a20aaf3-65ce-a7ae-8a0e-877313483969 at oracle.com/)
Applied to fixes, thanks. (We could have added the cc too, but thanks for doing
it!)


-Olof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help