[PATCH] net: stmmac: Fix stmmac_mdio_reset() when building stmmac as modules
From: davem@davemloft.net (David Miller)
Date: 2018-11-01 01:36:31
Also in:
lkml, netdev
From: davem@davemloft.net (David Miller)
Date: 2018-11-01 01:36:31
Also in:
lkml, netdev
From: Niklas Cassel <redacted> Date: Wed, 31 Oct 2018 16:08:10 +0100
When building stmmac, it is only possible to select CONFIG_DWMAC_GENERIC, or any of the glue drivers, when CONFIG_STMMAC_PLATFORM is set. The only exception is CONFIG_STMMAC_PCI. When calling of_mdiobus_register(), it will call our ->reset() callback, which is set to stmmac_mdio_reset(). Most of the code in stmmac_mdio_reset() is protected by a "#if defined(CONFIG_STMMAC_PLATFORM)", which will evaluate to false when CONFIG_STMMAC_PLATFORM=m. Because of this, the phy reset gpio will only be pulled when stmmac is built as built-in, but not when built as modules. Fix this by using "#if IS_ENABLED()" instead of "#if defined()". Signed-off-by: Niklas Cassel <redacted>
Applied and queued up for -stable, thanks.