Hi Sascha,

Hi Sascha,

quoted

quoted

quoted

+
+	ret = of_genpd_add_provider_simple(np, &imx_sc_pd->pd);
+	if (!ret)
+		return &imx_sc_pd->pd;
+
+	pm_genpd_remove_subdomain(genpd_parent, &imx_sc_pd->pd);
+
+err:
+	pr_warn("failed to add PM domain %pOF: %d\n", np, ret);

You have a struct device *, you should use dev_* functions.

Good suggestion.

A bit more thinking of it.

It may be not quite suitable to use dev_* here for print functions as we need
pass in a pointer of struct device for debug purpose only.
And we need change other two places as well which are in the same situation.

In current patch, we already define the print format at the top of the file.
#define pr_fmt(fmt) "scu_pd: " fmt
As SCU PD has only one device, it may does not help too much to use dev_*
functions.

Do you think it's reasonable?

If you're okay with this, I will drop this change and resend with other things
updated according to your suggestions.

Are you okay with this?

Regards
Dong Aisheng