Thread (42 messages) 42 messages, 3 authors, 2018-10-18

[PATCH V4 02/11] clk: imx: scu: add scu clock common part

From: aisheng.dong@nxp.com (A.s. Dong)
Date: 2018-10-17 15:28:45
Also in: linux-clk

-----Original Message-----
From: Stephen Boyd [mailto:sboyd at kernel.org]
Sent: Wednesday, October 17, 2018 11:07 PM
Quoting A.s. Dong (2018-10-17 02:11:03)
quoted
quoted
-----Original Message-----
From: Stephen Boyd [mailto:sboyd at kernel.org]
Sent: Wednesday, October 17, 2018 5:32 AM Quoting A.s. Dong
(2018-10-14 01:07:45)
quoted
Add scu clock common part which will be used by client clock drivers.

Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <redacted>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
ChangeLog:
v3->v4:
 * scu headfile path change
v2->v3:
 * no changes
v1->v2:
 * update function call name
---
 drivers/clk/imx/Kconfig       |  2 ++
 drivers/clk/imx/Makefile      |  2 ++
 drivers/clk/imx/scu/Kconfig   |  5 +++++
 drivers/clk/imx/scu/Makefile  |  4 ++++
drivers/clk/imx/scu/clk-scu.c | 17 +++++++++++++++++
drivers/clk/imx/scu/clk-scu.h | 18 ++++++++++++++++++
Why is scu nested one level deeper in the imx directory? Can't we
just keep them all within imx toplevel directory?
Mostly because SCU clocks are totally different from the legacy clocks.
(No much legacy things can be reused) So organized them together in a
deeper folder for clear separation and better maintenance

Do you think we still should put them within imx toplevel directory
and mix them with Legacy clocks?
Yes. Or make a new imx-foo directory for your new fangled SoC clk driver code
in drivers/clk/.
Okay, then let's still put them in the same imx directory.

Regards
Dong Aisheng
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help