On Fri, Oct 26, 2018 at 9:18 PM Liming Sun [off-list ref] wrote:

quoted

-----Original Message-----
From: arndbergmann at gmail.com [mailto:arndbergmann at gmail.com] On
Behalf Of Arnd Bergmann
Sent: Thursday, October 25, 2018 11:38 AM
To: Liming Sun <redacted>
Cc: Olof Johansson <redacted>; David Woods
[off-list ref]; Robin Murphy [off-list ref]; arm-
soc [off-list ref]; devicetree at vger.kernel.org; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v4 2/4] arm64: Add Mellanox BlueField SoC config option

On 10/24/18, Liming Sun [off-list ref] wrote:

quoted

This commit introduces config option for Mellanox BlueField SoC,
which can be used to build the SoC specific drivers, and enables
it by default in configs/defconfig.

Reviewed-by: David Woods <redacted>
Signed-off-by: Liming Sun <redacted>
---
 arch/arm64/Kconfig.platforms | 6 ++++++
 arch/arm64/configs/defconfig | 1 +
 2 files changed, 7 insertions(+)

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

I'm sorry for missing your series in the past. We should definitely merge
the platform support soon. Do you also have device tree files for reference
systems or even production hardware?

We have obsoleted the device tree, and mainly support ACPI now
on Reference/Production HW. Below is the TMFIFO definition in the ACPI
DSDT table.

    // RShim TMFIFO
    Device(RSH0) {
      Name(_HID, "MLNXBF01")
      Name(_UID, Zero)
      Name(_CCA, 1)
      Name(_CRS, ResourceTemplate() {
        Memory32Fixed(ReadWrite, 0x00800a20, 0x00000018)
        Memory32Fixed(ReadWrite, 0x00800a40, 0x00000018)
        Interrupt(ResourceConsumer, Edge, ActiveHigh, Exclusive)
          { BF1_RSH0_TM_HTT_LWM_INT,
            BF1_RSH0_TM_HTT_HWM_INT,
            BF1_RSH0_TM_TTH_LWM_INT,
            BF1_RSH0_TM_TTH_HWM_INT
          }
      })
    }

The full ACPI implementation can be found in the 1.0 release:
http://www.mellanox.com/downloads/BlueField/BlueField-1.0.0.10521/BlueField-1.0.0.10521.tar.xz
Inside this tarball, we can see the "src/edk2/" directory which has the edk2 patch file including all the ACPI implementation.

It would be nice if you could still include the dts sources in the submission.
Since this is not a classic server hardware, DT is probably more suitable
here, and there are likely use cases that won't work with ACPI, so it's
good to have a starting point for your users if they need to override
the ACPI tables with a DT, or build systems with a simpler boot loader.

       Arnd