Thread (15 messages) 15 messages, 5 authors, 2018-10-18

[PATCH 1/3] driver core: add probe_err log helper

From: javierm@redhat.com (Javier Martinez Canillas)
Date: 2018-10-16 09:32:40
Also in: lkml

Possibly related (same subject, not in this thread)

Hello Andrzej,

On 10/16/2018 09:22 AM, Andrzej Hajda wrote:
During probe every time driver gets resource it should usually check for error
printk some message if it is not -EPROBE_DEFER and return the error. This
pattern is simple but requires adding few lines after any resource acquisition
code, as a result it is often omited or implemented only partially.
probe_err helps to replace such code seqences with simple call, so code:
	if (err != -EPROBE_DEFER)
		dev_err(dev, ...);
	return err;
becomes:
	return probe_err(dev, err, ...);

Signed-off-by: Andrzej Hajda <redacted>
---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help