[PATCH 1/2] mmc: uniphier-sd: fix DMA disabling
From: Ulf Hansson <hidden>
Date: 2018-10-15 13:16:26
Also in:
linux-mmc, lkml
From: Ulf Hansson <hidden>
Date: 2018-10-15 13:16:26
Also in:
linux-mmc, lkml
On 12 October 2018 at 16:57, Masahiro Yamada [off-list ref] wrote:
Once DMA is enabled, it is not possible to disable it because uniphier_sd_dma_endisable() always sets the DMA_ENABLE_DMASDRW bit regardless of the argument 'enable'. It should disable DMA when 'enable' is false. Signed-off-by: Masahiro Yamada <redacted>
Applied for next, thanks! Kind regards Uffe
--- drivers/mmc/host/uniphier-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 10e7b30..10d49aa 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c@@ -78,7 +78,7 @@ static void *uniphier_sd_priv(struct tmio_mmc_host *host) static void uniphier_sd_dma_endisable(struct tmio_mmc_host *host, int enable) { - sd_ctrl_write16(host, CTL_DMA_ENABLE, DMA_ENABLE_DMASDRW); + sd_ctrl_write16(host, CTL_DMA_ENABLE, enable ? DMA_ENABLE_DMASDRW : 0); } /* external DMA engine */ --2.7.4