[PATCH 1/5] mm/sparse: add common helper to mark all memblocks present
From: hch@lst.de (Christoph Hellwig)
Date: 2018-10-11 13:30:13
Also in:
linux-mm, linux-riscv, linux-sh, lkml
+ for_each_memblock(memory, reg) {
+ int nid = memblock_get_region_node(reg);
+
+ memory_present(nid, memblock_region_memory_base_pfn(reg),
+ memblock_region_memory_end_pfn(reg));
Any reason you have a local variable for the node id while you happily
get away without one for the others? Why not simply:
for_each_memblock(memory, reg) {
memory_present(memblock_get_region_node(reg)
memblock_region_memory_base_pfn(reg),
memblock_region_memory_end_pfn(reg));
}