[PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler
From: Ezequiel Garcia <hidden>
Date: 2018-09-26 17:31:22
Also in:
linux-iommu, linux-rockchip
From: Ezequiel Garcia <hidden>
Date: 2018-09-26 17:31:22
Also in:
linux-iommu, linux-rockchip
On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote:
On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote:quoted
Printing verbosely via WARN macros and friends in interrupt handlers is strongly discouraged. Drop them and use proper ratelimited prints. Signed-off-by: Ezequiel Garcia <redacted> --- drivers/iommu/rockchip-iommu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)This doesn't apply cleanly to v4.19-rc5, can you please base the patch on that tag, add the Reviewed-by and re-send?
Well, after looking at the latest code, now I'm wondering why Marc changed the WARN_ON with a WARN_ON_ONCE, instead of a less verbose ratelimited print.