Thread (1 message) 1 message, 1 author, 2018-09-21
DORMANTno replies

[PATCH] ARM: dts: clearfog: fix sdhci supply property name

From: gregory.clement@bootlin.com (Gregory CLEMENT)
Date: 2018-09-21 14:05:33

Hi Russell King,
 
 On ven., sept. 21 2018, Russell King - ARM Linux [off-list ref] wrote:
On Fri, Sep 21, 2018 at 03:42:09PM +0200, Gregory CLEMENT wrote:
quoted
Hi Baruch,
 
 On mar., ao?t 21 2018, Baruch Siach [off-list ref] wrote:
quoted
The vmmc phandle, like all power supply property names, must have the
'-supply' suffix.
I also noticed it a few months ago and then I forgot. However, does it
add any value to have this regulator?

Now that I found my note, I considered to just remove this line as well
as the regulator node.
The "value" is it's a fuller description of the hardware, and DT is a
hardware description, not a description of what the software requires.
So, imho, it's completely correct to specify the vmmc.  As maintainer
for the Clearfog DT, I'd like it to stay (and be fixed).  Thanks.
OK so: applied on mvebu/dt

Thanks,

Gregory
-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up
-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help