[PATCH V6 2/3] firmware: imx: add SCU firmware driver support
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2018-09-20 06:52:20
From: s.hauer@pengutronix.de (Sascha Hauer)
Date: 2018-09-20 06:52:20
On Thu, Sep 20, 2018 at 06:41:15AM +0000, A.s. Dong wrote:
quoted
quoted
quoted
Could you give the exported functions a better namespace like imx_scu_*?Good idea. Should we change all the rest as well?You mean enums and such? Yes, that would be good.I mean other functions and struct names. All prefixed by imx_scu. Enums still not changed.
I don't really care about stuff that's internal to a single C file, but everything that is globally visible should have a proper namespace, Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |