[PATCH] arm64: dts: broadcom: Use the .dtb name in the rule, rather than .dts

On Tue, Sep 25, 2018 at 10:33 PM Stefan Wahren [off-list ref] wrote:

quoted

Olof Johansson [off-list ref] hat am 25. September 2018 um 20:51 geschrieben:


On Tue, Sep 25, 2018 at 11:17:52AM -0700, Florian Fainelli wrote:

quoted

On 09/24/2018 04:03 AM, Stefan Wahren wrote:

quoted

Am 24.09.2018 um 12:22 schrieb Liviu Dudau:

quoted

Commit a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute
Module IO Board V3") adds the bcm2837-rpi-cm3-io3.dts file as a target
in the Makefile, rather than the .dtb name. This will skip the
generation of the .dtb file at compile time and will fail the dtbs_install
target.

Fixes: a7eb26392b893 ("arm64: dts: broadcom: Add reference to Compute
Module IO Board V3")

Signed-off-by: Liviu Dudau <redacted>

Acked-by: Stefan Wahren <redacted>

Thanks, i will add a dtbs_install step to my test jobs.

Same here.

I do but I don't seem to catch any errors from it. :-/

Strange, i'm get getting this:

scripts/Makefile.dtbinst:31: Target ?bcm2837-rpi-cm3-io3.dts? passt nicht zum Ziel-Muster
  INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b-plus.dtb
  INSTALL arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dtb
  INSTALL
cp: Fehlender Zieldatei?Operand hinter '/tmp/broadcom'
?cp --help? liefert weitere Informationen.
scripts/Makefile.dtbinst:32: die Regel f?r Ziel ?bcm2837-rpi-cm3-io3.dts? scheiterte
make[2]: *** [bcm2837-rpi-cm3-io3.dts] Fehler 1
scripts/Makefile.dtbinst:35: die Regel f?r Ziel ?broadcom? scheiterte
make[1]: *** [broadcom] Fehler 2
arch/arm64/Makefile:139: die Regel f?r Ziel ?dtbs_install? scheiterte
make: *** [dtbs_install] Fehler 2

Oh, it fails but my reporting scripts don't notice it since I usually
don't capture errors from the install phase.


-Olof