Thread (47 messages) 47 messages, 5 authors, 2018-10-24

[PATCH 05/12] drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer

From: jagan@amarulasolutions.com (Jagan Teki)
Date: 2018-09-27 17:37:04
Also in: dri-devel, linux-clk, linux-devicetree, lkml

On Thu, Sep 27, 2018 at 10:48 PM Maxime Ripard
[off-list ref] wrote:
On Thu, Sep 27, 2018 at 05:18:43PM +0530, Jagan Teki wrote:
quoted
Short transfer write support for DCS and Generic transfer types
share similar way to process command sequence in DSI block so
add generic write 2 param transfer type macro so-that the panels
which are requesting similar transfer type may process properly.

Also added error check for unsupporting transfer types this make
debugging easy for new transfer types.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 156b371243c6..1c7e42015645 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -869,6 +869,7 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host,
                   SUN6I_DSI_CMD_CTL_TX_FLAG);

      switch (msg->type) {
+     case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM:
      case MIPI_DSI_DCS_SHORT_WRITE:
      case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
You should order them by alphabetical order.
I just placed it with transfer code, ok will add it alphabetical
quoted
              ret = sun6i_dsi_dcs_write_short(dsi, msg);
@@ -885,6 +886,8 @@ static ssize_t sun6i_dsi_transfer(struct mipi_dsi_host *host,
              }

      default:
+             dev_err(dsi->dev, "unsupported message type 0x%02x\n",
+                     msg->type);
And this isn't an error check.
But unsupported message type by sun6i_dsi should be an error
eventually isn't it? and we can easily figure out where the error
trigger.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help