-----Original Message-----
From: Scott Wood <oss@buserror.net>
Sent: Sunday, September 16, 2018 12:54 AM
To: Vabhav Sharma <redacted>; sudeep.holla at arm.com; linux-
kernel at vger.kernel.org; devicetree at vger.kernel.org; robh+dt at kernel.org;
mark.rutland at arm.com; linuxppc-dev at lists.ozlabs.org; linux-arm-
kernel at lists.infradead.org; mturquette at baylibre.com; sboyd at kernel.org;
rjw at rjwysocki.net; viresh.kumar at linaro.org; linux-clk at vger.kernel.org; linux-
pm at vger.kernel.org; linux-kernel-owner at vger.kernel.org;
catalin.marinas at arm.com; will.deacon at arm.com;
gregkh at linuxfoundation.org; arnd at arndb.de; kstewart at linuxfoundation.org;
yamada.masahiro at socionext.com
Cc: linux at armlinux.org.uk; Varun Sethi <redacted>; Udit Kumar
[off-list ref]; Yogesh Narayan Gaur
[off-list ref]; Andy Tang [off-list ref]
Subject: Re: [PATCH v2 3/5] drivers: clk-qoriq: Add clockgen support for lx2160a

On Fri, 2018-09-14 at 02:07 +0530, Vabhav Sharma wrote:

quoted

From: Yogesh Gaur <redacted>

Add clockgen support for lx2160a.
Added entry for compat 'fsl,lx2160a-clockgen'.

Signed-off-by: Tang Yuantian <redacted>
Signed-off-by: Yogesh Gaur <redacted>
Signed-off-by: Vabhav Sharma <redacted>
Acked-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/clk-qoriq.c         | 14 +++++++++++++-
 drivers/cpufreq/qoriq-cpufreq.c |  1 +
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index

3a1812f..e9ae70b 100644

--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c

@@ -79,7 +79,7 @@ struct clockgen_chipinfo {
 	const struct clockgen_muxinfo *cmux_groups[2];
 	const struct clockgen_muxinfo *hwaccel[NUM_HWACCEL];
 	void (*init_periph)(struct clockgen *cg);
-	int cmux_to_group[NUM_CMUX]; /* -1 terminates if fewer than

NUM_CMUX */
+	int cmux_to_group[NUM_CMUX+1]; /* -1 terminate if fewer to
NUM_CMUX+1 */

You need to add the -1 terminator to p4080, and remove the "if fewer"
comment since the whole point of this is that every array gets -1 terminated.

Ok, Updated

Why did you change "terminates" to "terminate" and "than" to "to"?

This +1 change should be a separate patch from lx2160a support.

Sure, Sending as separate patch

-Scott