Thread (3 messages) read the whole thread 3 messages, 2 authors, 2018-10-10

[PATCH 3/5] spi: pxa2xx: use an enum for type

From: robert.jarzmik@free.fr (Robert Jarzmik)
Date: 2018-09-21 20:34:11
Also in: linux-devicetree, linux-pci, linux-spi, lkml

Lubomir Rintel [off-list ref] writes:
That seems to be the correct type.
Okay, but what happens here when adev_id->driver_data is a value out of enum
range ? Does the following assignment make sense ?
+		type = (enum pxa_ssp_type)adev_id->driver_data;
As a side note, could you join for the next throw to the review :
 - Jarkko Nikula [off-list ref]
 - Mika Westerberg [off-list ref]

Even if they are Intel, I think they have worked a lot on this driver for Intel
platforms.

Cheers.

-- 
Robert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help