Thread (15 messages) 15 messages, 4 authors, 2018-09-18

[PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

From: Damian Kos <hidden>
Date: 2018-09-13 10:49:10
Also in: dri-devel, linux-devicetree, linux-rockchip, lkml

Thank you, Andrzej! I was a bit afraid that our patches are a bit too messy and thus ignored ?
Anyway, this patch (1/5) should be the last one that will cause such chaos in the DRM area.

Regards,
Damian

-----Original Message-----
From: Andrzej Hajda <redacted> 
Sent: Thursday, September 13, 2018 12:01
To: Damian Kos <redacted>; David Airlie <redacted>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Archit Taneja <redacted>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Gustavo Padovan <redacted>; Maarten Lankhorst <maarten.lankhorst@linux.intel.com>; Sean Paul <sean@poorly.run>; Sandy Huang <hjc@rock-chips.com>; Heiko St?bner <heiko@sntech.de>; Quentin Schulz <redacted>; dri-devel at lists.freedesktop.org; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-rockchip at lists.infradead.org
Cc: Przemyslaw Gaj <pgaj@cadence.com>; Lukasz Tyrala <redacted>; Scott Telford <redacted>; Artur Jedrysek <redacted>; Piotr Sroka <redacted>
Subject: Re: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver

EXTERNAL MAIL


Hi Damian,

Quite late but.

On 28.08.2018 12:24, Damian Kos wrote:
- Extracted common fields from cdn_dp_device to a new cdns_mhdp_device
  structure which will be used by two separate drivers later on.
- Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format,
  video_info) from cdn-dp-core.c to cdn-dp-reg.h.
- Changed prefixes from cdn_dp to cdns_mhdp
    cdn -> cdns to match the other Cadence's drivers
    dp -> mhdp to distinguish it from a "just a DP" as the IP underneath
      this registers map can be a HDMI (which is internally different,
      but the interface for commands, events is pretty much the same).
- Modified cdn-dp-core.c to use the new driver structure and new function
  names.

Signed-off-by: Damian Kos <redacted>
Many changes, hard to review. Anyway:

Reviewed-by: Andrzej Hajda <redacted>

?--
Regards
Andrzej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help