[PATCH v6 11/11] arm64: annotate user pointers casts detected by sparse

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
2018-09-06 21:13:56
Also in
linux-arch, linux-doc, linux-kselftest, linux-mm, lkml
Reply to
Andrey Konovalov, 2018-08-30
On Thu, Aug 30, 2018 at 4:41 AM Andrey Konovalov [off-list ref] wrote:
This patch adds __force annotations for __user pointers casts detected by
sparse with the -Wcast-from-as flag enabled (added in [1]).
No, several of these are wrong, and just silence a warning that shows a problem.

So for example:
quoted hunk ↗ jump to hunk
 static inline compat_uptr_t ptr_to_compat(void __user *uptr)
 {
-       return (u32)(unsigned long)uptr;
+       return (u32)(__force unsigned long)uptr;
 }
this actually looks correct.

But:
quoted hunk ↗ jump to hunk
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -76,7 +76,7 @@ static inline unsigned long __range_ok(const void __user *addr, unsigned long si
 {
        unsigned long ret, limit = current_thread_info()->addr_limit;

-       __chk_user_ptr(addr);
+       __chk_user_ptr((void __force *)addr);
This looks actively wrong. The whole - and only - point of
"__chk_user_ptr()" is that it warns about a lack of a "__user *" type.

So the above makes no sense at all.

There are other similar "that makes no sense what-so-ever", like this one:
-               struct compat_group_req __user *gr32 = (void *)optval;
+               struct compat_group_req __user *gr32 = (__force void *)optval;
no, the additionl of __force is not the right thing, the problem, is
that a __user pointer is cast to a non-user 'void *' only to be
assigned to another user type.

The fix should have been to use (void __user *) as the cast instead,
no __force needed.

In general, I think the patch shows all the signs of "mindlessly just
add casts", which is exactly the wrong thing to do to sparse warnings.

                   Linus
Thread (33 messages) 33 messages, 6 authors, last reply 2018-10-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help