[PATCH v3 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic

On Tue, Aug 07, 2018 at 09:03:27AM +0100, Alexandru-Cosmin Gheorghe wrote:

Hi Sinclair,

Is it ok if I merge this patch through drm-misc-next ?

Sure. Thanks for handling this.

Sinclair

Thank you,
Alex Gheorghe

On Mon, Aug 06, 2018 at 09:57:53AM -0700, Sinclair Yeh wrote:

quoted

Acked-by: Sinclair Yeh <redacted>

On Sat, Aug 04, 2018 at 05:15:30PM +0100, Alexandru Gheorghe wrote:

quoted

A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.

Reviewed-by: Sinclair Yeh <redacted>
Reviewed-by: Deepak Rawat <redacted>
Signed-off-by: Alexandru Gheorghe <redacted>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 4a0f0f41afa1..61824e360619 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

@@ -720,9 +720,7 @@ void vmw_du_plane_reset(struct drm_plane *plane)
 		return;
 	}
 
-	plane->state = &vps->base;
-	plane->state->plane = plane;
-	plane->state->rotation = DRM_MODE_ROTATE_0;
+	__drm_atomic_helper_plane_reset(plane, &vps->base);
 }
 
 

-- 
2.18.0

-- 
Cheers,
Alex G