[PATCH 2/3] clk: imx6q: optionally get CCM inputs via standard clock handles
From: robh@kernel.org (Rob Herring)
Date: 2018-08-09 22:41:24
Also in:
linux-devicetree
From: robh@kernel.org (Rob Herring)
Date: 2018-08-09 22:41:24
Also in:
linux-devicetree
Hi, this is an automated email from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Tue, 31 Jul 2018 12:20:08 +0200, Lucas Stach wrote:
When specifying external clock inputs to the CCM the current code requires the clocks to be in a "clocks" child node of the DT root. This is not really conformant with DT best practices. To avoid the need to deviate from those best practices, allow the clock inputs to be specifies via standard clock handles. This is in line with how drivers of the later CCM driver revisions on newer i.MX SoCs handle this. As we can't retroactively change the DT binding, allow this as an option with a fallback to the old way of how this has been handled. Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
--- .../devicetree/bindings/clock/imx6q-clock.txt | 5 +++++ drivers/clk/imx/clk-imx6q.c | 22 ++++++++++++++----- 2 files changed, 22 insertions(+), 5 deletions(-)
DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.