[PATCH v2] EDAC, ghes: use CPER module handles to locate DIMMs
From: Tyler Baicar <hidden>
Date: 2018-08-30 19:18:08
Also in:
linux-edac, lkml
Hi Fan, On Thu, Aug 30, 2018 at 2:37 PM, Fan Wu [off-list ref] wrote:
For platforms whose firmwares provide valid module handles (SMBIOS type 17) in error records, this patch uses the module handles to locate corresponding DIMMs and enables per-DIMM error counter update. Signed-off-by: Fan Wu <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index 473aeec..949f603 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c@@ -81,6 +81,20 @@ static void ghes_edac_count_dimms(const struct dmi_header *dh, void *arg) (*num_dimm)++; } +static int get_dimm_smbios_index(u16 handle) +{ + struct mem_ctl_info *mci; + int i; + + mci = ghes_pvt->mci; +
Minor nit: you could define and set mci in the same line to save some space here. Otherwise this patch looks good to me. Reviewed-by: Tyler Baicar <redacted>