Thread (3 messages) 3 messages, 3 authors, 2018-08-29

[PATCH] drm/rockchip: Use struct_size() in devm_kzalloc()

From: heiko@sntech.de (Heiko Stuebner)
Date: 2018-08-29 11:42:08
Also in: dri-devel, linux-rockchip, lkml

Am Sonntag, 26. August 2018, 20:47:12 CEST schrieb Gustavo A. R. Silva:
One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
	int stuff;
        void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

or, like in this particular case:

size = sizeof(struct foo) + sizeof(void *) * count;
instance = devm_kzalloc(dev, size, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count),
GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
applied to drm-misc with Kees' Review

Thanks
Heiko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help