On 08/17/2018 05:52 PM, Andrew Lunn wrote:

On Fri, Aug 17, 2018 at 04:47:39PM -0700, justinpopo6 at gmail.com wrote:

quoted

From: Justin Chen <redacted>

Sometimes we have empty banks within the GPIO block. This commit allows
proper handling of 0 width GPIO banks.

Hi Justin

This is coming from DT? Why do you put 0 width banks in DT in the
first place?

The way the binding is defined, the "reg" property must cover the entire
GPIO block. On our chips we typically have two blocks, one called GIO
and one called AON_GIO. One of our chips, BCM7429 unfortunately does not
have contiguous banks (groups of 32 GPIOs) within the GIO register
range, it has a first bank from 0 -> 0x20, then nothing, then another
one from 0x40 -> 0x60, which is why this change was proposed, since it
does not break any existing DT blob.
-- 
Florian