[PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet
From: ludovic.desroches@microchip.com (Ludovic Desroches)
Date: 2018-08-20 09:29:25
Also in:
dmaengine, lkml
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote:
as you are already in a tasklet, it is unnecessary to call spin_lock_bh. Signed-off-by: Barry Song <redacted>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks
quoted hunk ↗ jump to hunk
--- drivers/dma/at_xdmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 4bf7256..4e55768 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c@@ -1600,7 +1600,7 @@ static void at_xdmac_tasklet(unsigned long data) if (atchan->status & AT_XDMAC_CIS_ROIS) dev_err(chan2dev(&atchan->chan), "request overflow error!!!"); - spin_lock_bh(&atchan->lock); + spin_lock(&atchan->lock); desc = list_first_entry(&atchan->xfers_list, struct at_xdmac_desc, xfer_node);@@ -1610,7 +1610,7 @@ static void at_xdmac_tasklet(unsigned long data) txd = &desc->tx_dma_desc; at_xdmac_remove_xfer(atchan, desc); - spin_unlock_bh(&atchan->lock); + spin_unlock(&atchan->lock); if (!at_xdmac_chan_is_cyclic(atchan)) { dma_cookie_complete(txd);-- 2.7.4