[PATCH 1/2] coresight: etb10: Refactor etb_drvdata::mode handling
From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
Date: 2018-08-16 15:13:08
Also in:
lkml
Hi Mathieu, The patch looks good to me. One minor nit below. On 14/08/18 23:14, Mathieu Poirier wrote:
quoted hunk ↗ jump to hunk
This patch moves the etb_drvdata::mode from a locat_t to a simple u32, as it is for the ETF and ETR drivers. This streamlines the code and adds commonality with the other drivers when dealing with similar operations. Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> --- drivers/hwtracing/coresight/coresight-etb10.c | 62 +++++++++++++++------------ 1 file changed, 34 insertions(+), 28 deletions(-)diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index 9fd77fdc1244..69287163ce4e 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c
quoted hunk ↗ jump to hunk
@@ -488,7 +494,7 @@ static void etb_dump(struct etb_drvdata *drvdata) unsigned long flags; spin_lock_irqsave(&drvdata->spinlock, flags); - if (local_read(&drvdata->mode) == CS_MODE_SYSFS) { + if (drvdata->mode == CS_MODE_SYSFS) { etb_disable_hw(drvdata); etb_dump_hw(drvdata); etb_enable_hw(drvdata);
Looks good to me. Reviewed-by : Suzuki K Poulose [off-list ref]