Thread (10 messages) 10 messages, 2 authors, 2018-08-08

[PATCH 2/2] iommu/rockchip: Move irq request past pm_runtime_enable

From: heiko@sntech.de (Heiko Stuebner)
Date: 2018-08-07 11:45:37
Also in: linux-iommu, linux-rockchip, lkml

Am Dienstag, 7. August 2018, 10:54:06 CEST schrieb Marc Zyngier:
Enabling the interrupt early, before power has been applied to the
device, can result in an interrupt being delivered too early if:

- the IOMMU shares an interrupt with a VOP
- the VOP has a pending interrupt (after a kexec, for example)

In these conditions, we end-up taking the interrupt without
the IOMMU being ready to handle the interrupt (not powered on).

Moving the interrupt request past the pm_runtime_enable() call
makes sure we can at least access the IOMMU registers. Note that
this is only a partial fix, and that the VOP interrupt will still
be screaming until the VOP driver kicks in, which advocates for
a more synchronized interrupt enabling/disabling approach.

Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
Signed-off-by: Marc Zyngier <redacted>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help