Thread (38 messages) 38 messages, 4 authors, 2018-09-03
STALE2841d

[PATCH v4 02/20] virtio: pci-legacy: Validate queue pfn

From: mst@redhat.com (Michael S. Tsirkin)
Date: 2018-07-23 14:20:11
Also in: kvm, kvmarm

On Mon, Jul 23, 2018 at 01:54:10PM +0100, Marc Zyngier wrote:
On 23/07/18 10:44, Suzuki K Poulose wrote:
quoted
On 07/22/2018 04:53 PM, Michael S. Tsirkin wrote:
quoted
On Wed, Jul 18, 2018 at 10:18:45AM +0100, Suzuki K Poulose wrote:
quoted
Legacy PCI over virtio uses a 32bit PFN for the queue. If the
queue pfn is too large to fit in 32bits, which we could hit on
arm64 systems with 52bit physical addresses (even with 64K page
size), we simply miss out a proper link to the other side of
the queue.

Add a check to validate the PFN, rather than silently breaking
the devices.

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Marc Zyngier <redacted>
Cc: Christoffer Dall <cdall@kernel.org>
Cc: Peter Maydel <redacted>
Cc: Jean-Philippe Brucker <redacted>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>

Michael,

Thanks.
quoted
I assume this will be merged through some other tree.

As such these two virtio patches do not have any code dependencies with
the rest of the series. So, if you could pick this up it should be fine.
Otherwise, may be Marc can push it with the rest of the series.

Marc,

Are you OK with that ?
Given that these two patches completely independent, I think their
natural path should be the virtio tree. But if Michael doesn't want to
pick them, I'll do it as part of this series.

Thanks,

	M.
It's ok, I can pick them up.
-- 
Jazz is not dead. It just smells funny...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help