Thread (36 messages) 36 messages, 5 authors, 2018-07-09

[linux-sunxi] Re: [PATCH 05/10] arm64: dts: allwinner: a64: Olinuxino: enable USB

From: andre.przywara@arm.com (Andre Przywara)
Date: 2018-07-06 16:17:14

Hi,

On 06/07/18 16:50, Icenowy Zheng wrote:

? 2018?7?6? GMT+08:00 ??11:46:08, Andre Przywara [off-list ref] ??:
quoted
Hi,

On 06/07/18 16:36, Icenowy Zheng wrote:
quoted

? 2018?7?6? GMT+08:00 ??11:35:38, Andre Przywara
[off-list ref] ??:
quoted
quoted
Hi,

On 06/07/18 16:04, Martin Lucina wrote:
quoted
On Friday, 06.07.2018 at?09:52, Andre Przywara wrote:
quoted
The Olinuxino has two USB socket:
USB0 is connected to a micro B socket. As it has the ID pin wired,
we
quoted
quoted
describe it as a proper OTG socket, which switches between host
and
quoted
quoted
quoted
quoted
device automatically.
USB1 is connected to a normal USB A socket. PG9 enables the power
line,
quoted
quoted
so add the required regulator as well.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
This is not sufficient. Booting with this change results in the
following
quoted
in dmesg:

musb-sunxi 1c19000.usb: Invalid or missing 'dr_mode' property
musb-sunxi: probe of 1c19000.usb failed with error -22
[...]
usb0-vbus: disabling

... and neither of the USB ports work.

Adding

    dr_mode = "host";
Argh, right, I remember you mentioned this before.
Still it should not affect the other USB port, and actually it is a
proper OTG port, so host is not right here. So this points to some
other
oddity or incorrect description. I need to go back to the schematics
and
our previous thread.
OTG needs dr_mode = "otg"; and a ID pin.
Yes, and we have the ID pin in the usbphy node.
Martin, can you please check if dr_mode = "otg"; works for you?

Icenowy: still, how does it affect USB1? I mean, even if MUSB does not
initialise, it should leave the other host controller working? Is that
related to them sharing the usbphy? And this one gives up and tears
*everything* down, including the power for USB1?
You wrongly bound the regulator to USB0, not USB1.
Oh dear ...
USB0 regulator should be AXP's drivevbus if it's OTG in generic
design based on AW reference.
Yes, it is.
So, like this?

--------------
	reg_usb0_vbus: usb0-vbus { ....
		(unchanged)
	};
};
....
&reg_drivevbus {
	regulator-name = "usb0-vbus";
	status = "okay";
};

&usb_otg {
	dr_mode = "otg";
	status = "okay";
};

&usbphy {
	usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
	usb0_vbus-supply = <&reg_drivevbus>;
	usb1_vbus-supply = <&reg_usb0_vbus>;
};
--------------

Martin, can you please give this a try? (It's PH9, not PH6 as in the
original patch).

Cheers,
Andre.
(No OLinuXino A64 schematics on hand)
quoted
Cheers,
Andre.
quoted
quoted
quoted
to the &usb_otg node fixes this -- the above messages go away and
both
quoted
ports work as expected.

-mato
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help