On Sat, Jul 21, 2018 at 4:14 PM Hedges Alexander
[off-list ref] wrote:

An overarching question:

the whole patch set contains things like this:

+#ifdef CONFIG_OF

(...)

+#else

(...)

+#endif

But arch/arm/mach-zynq and the Aarch64 counterpart are
OF-only.

I.e. these adaptions must have been made for some Xilinx
platform support codebase that is not upstream, and which does
not use device tree.

If this is the case, I insist that these non-OF platforms are
upstreamed *first*, because we are trying to get rid of
non-OF platforms from the ARM kernel, and the Aarch64
kernel simply does not allow them (unless they are instead
using ACPI). It is as far as I can tell code that cannot be
tested with any machine supported in the upstream kernel
and the upstream kernel should only contain code that
can be executed with an unpatched kernel.

Yours,
Linus Walleij