Thread (10 messages) 10 messages, 4 authors, 2018-07-14

[PATCH -next] pinctrl: nsp: fix potential NULL dereference in nsp_pinmux_probe()

From: Linus Walleij <hidden>
Date: 2018-07-13 07:46:01
Also in: kernel-janitors, linux-gpio

On Wed, Jul 11, 2018 at 2:25 PM Wei Yongjun [off-list ref] wrote:
platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Signed-off-by: Wei Yongjun <redacted>
Patch applied with Ray's ACK.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help