Hi Krzysztof,

On 2018-07-23 19:52, Krzysztof Kozlowski wrote:

Hi All,

Changes since v1
================
1. Add Tomasz's ack.
2. Reword description in patch 6/10.


Tests
=====
This is both request for comments and requests for tests. Only basic
tests were done, including suspend to RAM on Odroid U3 (Exynos4412)
with max7768 RTC wakeup. Please kindly test it with devices capable of
suspending and resuming. I am mostly thinking about S5Pv210-based (Aria),
Trats, Trats2 and TM2 (Exynos5433). Existing platforms should not be
broken however changing external interrupt wakeup mask was not done
on Exynos5433.

Works fine on Exynos5433 TM2 with some additional patches related to
suspend/resume handling of the PMU. It handles only EINT0..EINT31 pins
for now. Exynos5433 has more external interrupt wakeup lines: EINT32-63
located at banks GPF1[0..7], GPF2[0..3], GPF3[0..3], GPF4[0..7] and
GPF5[0..7]. They can be configured as wakeup sources in
EXYNOS5433_EINT_WAKEUP_MASK1 (0x062C) PMU register. Handling of them
can be added later when it will be really needed.

Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>

Description
===========
The Exynos/S5Pv210 machine suspend code needs to write the external
interrupt mask during suspend.  The mask is controlled by pin controller
driver: the exynos_wkup_irq_set_wake() in IRQ chip for these wakeup
interrupts.

Therefore pinctrl driver code exposed an exynos_get_eint_wake_mask()
function which was later used as an extern in machine code.

This is quite ugly way of combining driver and machine code,
not portable triggering Sparse and GCC warnings.


This might break suspend capability S5Pv210 on with older DTBs (thus
breaks DTB compatibility), however:
1. just "might" because in case of using older DTB, the wakeup mask
    will not be changed during suspend and default reset value (all
    interrupts non-masked) should work,
2. mainline support for S5Pv210 with DTB is limited and suspend
    to RAM already might be broken.


Dependencies
============
1. The first seven patches should be taken through one tree,
    preferably samsung-pinctrl,
2. The DTS patch (7/10) for S5Pv210 should go into next cycle,
3. The remaining patches (8-10) should go after all previous,
    so probably another release cycle.


Best regards,
Krzysztof

Krzysztof Kozlowski (10):
   pinctrl: samsung: Define suspend and resume callbacks for all banks
     and SoCs
   pinctrl: samsung: Document suspend and resume members
   pinctrl: samsung: Document hidden requirement about one external
     wakeup
   pinctrl: samsung: Add dedicated compatible for S5Pv210 wakeup
     interrupts
   ARM: exynos: Define EINT_WAKEUP_MASK registers for S5Pv210 and
     Exynos5433
   pinctrl: samsung: Write external wakeup interrupt mask
   ARM: dts: s5pv210: Switch to S5Pv210 specific pinctrl wakeup
     compatible
   ARM: s5pv210: Remove legacy setting of external wakeup interrupts
   ARM: exynos: Remove legacy setting of external wakeup interrupts
   pinctrl: samsung: Remove legacy API for handling external wakeup
     interrupts mask

  .../bindings/pinctrl/samsung-pinctrl.txt           | 11 ++-
  arch/arm/boot/dts/s5pv210.dtsi                     |  2 +-
  arch/arm/mach-exynos/common.h                      |  2 -
  arch/arm/mach-exynos/suspend.c                     | 16 +++--
  arch/arm/mach-s5pv210/common.h                     |  1 -
  arch/arm/mach-s5pv210/pm.c                         | 16 +++--
  drivers/pinctrl/samsung/pinctrl-exynos-arm.c       | 16 +++++
  drivers/pinctrl/samsung/pinctrl-exynos.c           | 78 +++++++++++++++++++---
  drivers/pinctrl/samsung/pinctrl-samsung.h          | 11 +++
  include/linux/soc/samsung/exynos-regs-pmu.h        |  8 ++-
  10 files changed, 136 insertions(+), 25 deletions(-)

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland