[PATCH v2 04/10] coresight: platform: Fix leaking device reference
flat view
STALE2998d
From: suzuki.poulose@arm.com (Suzuki K Poulose)
Date: 2018-07-19 10:55:53
Also in:
linux-devicetree, lkml
Subsystem:
arm/coresight framework and drivers, hardware tracing facilities, the rest · Maintainers:
Suzuki K Poulose, Alexander Shishkin, Linus Torvalds
Revision v2 of 4 in this series.
Revisions (4)
- rfc [diff vs current]
- v1 [diff vs current]
- v2 current
- v3 [diff vs current]
We don't drop the reference on the remote device while parsing the connection, held by bus_find_device(). Fix this by duplicating the device name and dropping the reference. Cc: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Kim Phillips <redacted> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- - New in v2 --- drivers/hwtracing/coresight/of_coresight.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index 6c2f95a..c5f664c 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c@@ -161,7 +161,9 @@ static int of_coresight_parse_endpoint(struct device *dev, } pdata->outports[*i] = endpoint.port; - pdata->child_names[*i] = dev_name(rdev); + pdata->child_names[*i] = devm_kstrdup(dev, + dev_name(rdev), + GFP_KERNEL); pdata->child_ports[*i] = rendpoint.id; /* Move the index */ (*i)++;
@@ -171,6 +173,8 @@ static int of_coresight_parse_endpoint(struct device *dev, of_node_put(rparent); if (rport) of_node_put(rport); + if (rdev) + put_device(rdev); return ret; }
--
2.7.4