[resend PATCH v4 5/5] drm: mediatek: Omit warning on probe defers
From: sean.wang@mediatek.com (Sean Wang)
Date: 2018-07-18 03:09:41
Also in:
dri-devel, linux-clk, linux-mediatek, lkml
From: sean.wang@mediatek.com (Sean Wang)
Date: 2018-07-18 03:09:41
Also in:
dri-devel, linux-clk, linux-mediatek, lkml
On Wed, 2018-07-18 at 00:03 +0200, matthias.bgg at kernel.org wrote:
From: Matthias Brugger <mbrugger@suse.com> It can happen that the clock drivers wasn't probed before the ddp driver gets invoked. The driver used to omit a warning that the driver failed to get the clocks. Omit this error on the defered probe path.
so if we list drm device as a child device of mmsys we don't need the patch, and that make more sense.
Signed-off-by: Matthias Brugger <mbrugger@suse.com> Acked-by: CK Hu <redacted> --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index bafc5c77c4fb..6b399348a2dc 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c@@ -374,7 +374,8 @@ static int mtk_ddp_probe(struct platform_device *pdev) ddp->clk = devm_clk_get(dev, NULL); if (IS_ERR(ddp->clk)) { - dev_err(dev, "Failed to get clock\n"); + if (PTR_ERR(ddp->clk) != -EPROBE_DEFER) + dev_err(dev, "Failed to get clock\n"); return PTR_ERR(ddp->clk); }