[PATCH] pwm-omap: handle timers not ready in probe
From: David Rivshin <hidden>
Date: 2018-07-16 15:56:07
Also in:
linux-omap, linux-pwm, lkml
From: David Rivshin <hidden>
Date: 2018-07-16 15:56:07
Also in:
linux-omap, linux-pwm, lkml
On Mon, 16 Jul 2018 10:37:20 +0200 Pavel Machek [off-list ref] wrote:
On Mon 2018-07-16 00:57:40, Tony Lindgren wrote:quoted
* Pavel Machek [off-list ref] [180716 07:16]:quoted
When all the drivers are built-in, timers are not ready and probing fails. Fix that with -EPROBE_DEFFER. Signed-off-by: Pavel Machek <redacted>diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c index 665da3c..debeb70 100644 --- a/drivers/pwm/pwm-omap-dmtimer.c +++ b/drivers/pwm/pwm-omap-dmtimer.c@@ -265,7 +271,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) timer_pdata = dev_get_platdata(&timer_pdev->dev); if (!timer_pdata) { dev_err(&pdev->dev, "dmtimer pdata structure NULL\n"); - ret = -EINVAL; + ret = -EPROBE_DEFER; goto put; }There seems to be an earlier similar patch, care to take a look at "[PATCH] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data"?Yes, that one is equivalent. You can add Acked-by: Pavel Machek <redacted> Tested-by: Pavel Machek <redacted> on it. Thanks, Pavel
Thanks Pavel. I hadn't been watching the Droid 4 threads, so I didn't see you were hitting the same problem. I'm assuming the patch will go through the PWM tree, so copying in Thierry.