Thread (1 message) 1 message, 1 author, 2018-07-16

[PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

From: khilman@baylibre.com (Kevin Hilman)
Date: 2018-07-16 13:41:40
Also in: linux-amlogic, linux-clk, lkml

Jian Hu [off-list ref] writes:
On 2018/7/10 5:53, Martin Blumenstingl wrote:
quoted
On Mon, Jul 9, 2018 at 1:14 PM Jian Hu [off-list ref] wrote:
[...]
quoted
quoted
+static const struct of_device_id clkc_match_table[] = {
+       { .compatible = "amlogic,g12a-clkc" },
I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
correct - I'll CC Rob Herring on the dt-bindings patch)
For clock drivers,they omit the "meson-" prefix, But for common
amlogic drivers use "amlogic.meson-<chip>-<ip>".
So which type should we choose? .compatible = "amlogic,g12a-clkc or

.compatible = "amlogic,meson-g12a-clkc
Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help